[llvm-dev] [RFC] Fail early on unimplementable append linkage uses

Rafael EspĂ­ndola via llvm-dev llvm-dev at lists.llvm.org
Fri May 13 08:09:23 PDT 2016


On 13 May 2016 at 10:11, Renato Golin <renato.golin at linaro.org> wrote:
> On 13 May 2016 at 13:56, Rafael EspĂ­ndola <rafael.espindola at gmail.com> wrote:
>> No. Clang only produces the well known ones. Anything producing a
>> appending linkage global that actually got written to the output would
>> hit a link error if it tried combining any two of those files (and can
>> get the same behaviour with an external linkage).
>
> I wonder what was the motivation to add that piece of code, then. It
> sounds to me that it was wrong to do that in the first place.

I agree. The revisions in question seem to be r41048 and before that
r8417. From reading them I think it was just a mistake about how
object files work.

Cheers,
Rafael


More information about the llvm-dev mailing list