[llvm-dev] Sincos for X86_64's GNUX32 and ARM's GNUEABI/GNUEABIHF enviroments

[Renato Golin via llvm-dev]

On 15 June 2016 at 11:24, Daniel Sanders via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> I've noticed that the GNUX32 and GNUEABI/GNUEABIHF environments don't make use of the sincos libcall like the GNU environment does because the guarding condition for this is 'TT.getEnvironment() == Triple::GNU'. The comment in canCombineSinCosLibcall() in LegalizeDAG.cpp suggests that it's intending to use sincos for all GNU environments so I'm wondering whether the exclusion of GNUX32/GNUEABI/GNUEABIHF is deliberate or not.

Hi Daniel,

I don't remember anything deliberate about that. But I haven't been
playing around sin/cos much. To me, it looks like an omission more
than anything.

cheers,
--renato