[llvm-dev] RFC: FileCheck Enhancements

[Robinson, Paul via llvm-dev]

> -----Original Message-----
> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of
> Michael Kruse via llvm-dev
> Sent: Friday, June 03, 2016 11:03 AM
> To: James Y Knight
> Cc: llvm-dev
> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements
> 
> 2016-05-26 18:13 GMT+02:00 James Y Knight via llvm-dev
> <llvm-dev at lists.llvm.org>:
> > For "6. Check statement for words only" -- I think it might be better to
> > just make that be the ONLY behavior, rather than an additional option --
> if
> > you intended to end a match in the middle of  a word, stick {{[^ ]*}} on
> it.
> 
> I support this. I found it very confusing when
> ; CHECK-NEXT: br
> to check for a branch instruction also matched a line eg.
> %2 = add i32 %subregion, i32 5
> 
> However, it is a breaking change and therefore might require changes
> in existing tests.

Definitely.  I've seen things like "CHECK: lea" which is intentionally
insensitive to "leal" versus "leaq" as the generated X86 instruction.
It would take a while to find all such tests and make them tolerate a 
word-based FileCheck.
--paulr

> 
> Michael
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev