[llvm-dev] [lld] r271569 - Start adding tlsdesc support for aarch64.

Renato Golin via llvm-dev llvm-dev at lists.llvm.org
Thu Jun 2 13:19:19 PDT 2016


On 2 June 2016 at 20:49, Rafael Espindola via llvm-commits
<llvm-commits at lists.llvm.org> wrote:
> Author: rafael
> Date: Thu Jun  2 14:49:53 2016
> New Revision: 271569
>
> URL: http://llvm.org/viewvc/llvm-project?rev=271569&view=rev
> Log:
> Start adding tlsdesc support for aarch64.
>
> This is mostly extracted from http://reviews.llvm.org/D18960.

Rafael,

Why commit part of Adhemerval's patch without reviewing his request?
This is a really serious breach of community trust.

Not only we're waiting for reviews on the TLS set of patches and
having to rebase every two weeks, but now you implemented in a way
that wasn't discussed on the review, didn't mention authorship, nor
asked Adhemerval for any input.

If you had technical input on his patch, you should have done on the
review. If you wanted him to split in smaller patches, you should have
asked on the review and let *him* do it.

Even if you were the code owner (which you're not), it would still be
a *serious* breach of trust and respect.

I hereby respectfully request that you revert your patch and let
Adhemerval finish the work that he started in the way that we normally
do in the LLVM community.

regards,
--renato


More information about the llvm-dev mailing list