[llvm-dev] [cfe-dev] GitHub anyone?

James Y Knight via llvm-dev llvm-dev at lists.llvm.org
Thu Jun 2 11:25:04 PDT 2016


We could also think about using gerrit in the future to manage code reviews
and commits into the repository. (perhaps via the gerrithub.io hosted
platform, which also has github integration, including the ability to deal
with pull requests).

Gerrit already has pretty good support for cross-repository changes (via
assigning a bunch of commits to the same "topic", so they can be reviewed
together).

It also already supports making the submodule commits for the
"llvm-project" superproject. And it is supposed to "soon" support doing an
atomic commit of a "topic" across multiple repositories, which could then
show up as a single change in the "llvm-project" superproject repository. I
don't believe it does that atomically right now, but that's in the plans.

I have found gerrit a really nice code review system in the past for other
projects, and I'm a little afraid that github's PR system will not be
featureful enough by itself. But, maybe it will.

On Thu, Jun 2, 2016 at 2:06 PM, via cfe-dev <cfe-dev at lists.llvm.org> wrote:

> Richard Smith via llvm-dev <llvm-dev at lists.llvm.org> writes:
>
> >     How would you ensure that two dependent changes on different
> >     repositories get the same revision number?
> >
> > That is not the case today and isn't (in my opinion) a problem we need
> > to solve with this migration. If there's a small (1-2 revision) window
> > in which things are broken, that's annoying but not a showstopper and
> > not a regression.
>
> With git-subtree you could commit both changes atomically in the "host"
> repository, then split out the histories to the individual components.
>
>                              -David
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160602/61ef12c8/attachment-0001.html>


More information about the llvm-dev mailing list