[llvm-dev] FreeBSD user willing to try fix a unit test?

Pete Cooper via llvm-dev llvm-dev at lists.llvm.org
Mon Jul 25 10:29:00 PDT 2016


> On Jul 23, 2016, at 4:01 PM, Tim Northover <t.p.northover at gmail.com> wrote:
> 
> On 23 July 2016 at 11:08, Dimitry Andric via llvm-dev
> <llvm-dev at lists.llvm.org> wrote:
>> Let's just drop the || !defined(__FreeBSD__) part.  Btw, any idea what the
>> defined(__llvm__) part is supposed to accomplish?
> 
> It was added in the same commit, and given the comment above I think
> it's probably so the test still runs on FreeBSD if Clang is
> self-hosting.
Yeah, thats the way I read it too.  So this is really just trying to single out gcc 4.2.1 on FreeBSD as the illegal target.

Thanks for running this Dimitry.  I appreciate it.

Can you commit the removal of #if or would you prefer me to?

Thanks again,
Pete
> 
> Tim.



More information about the llvm-dev mailing list