[llvm-dev] RFC: FileCheck Enhancements

David Blaikie via llvm-dev llvm-dev at lists.llvm.org
Mon Jul 18 09:48:08 PDT 2016


It still doesn't include the original context/description of the patch,
though. Yes, you can copy/paste that in, though.

On Mon, Jul 18, 2016 at 4:27 AM James Y Knight via llvm-dev <
llvm-dev at lists.llvm.org> wrote:

> It does send a patch to the list if you upload a new diff to the existing
> review after adding the list as a subscriber. That seems the best way to go
> usually?
>
> On Jul 15, 2016 8:36 PM, "Mehdi Amini via llvm-dev" <
> llvm-dev at lists.llvm.org> wrote:
>
>> > On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <
>> llvm-dev at lists.llvm.org> wrote:
>> >
>> > Please add llvm-commits as a subscriber to all of these reviews
>> > so everyone has a chance to see/comment on them.
>>
>> Adding llvm-commits after the fact ends up in the mailing list not
>> archiving the context of the reviews.
>> If these patches are fresh (no significant review occurred), they should
>> be closed and new revisions need to be opened, with llvm-commits as a
>> subscriber from the start.
>>
>>
>>>> Mehdi
>>
>>
>> > Thanks,
>> > --paulr
>> >
>> >> -----Original Message-----
>> >> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of
>> Elena
>> >> Lepilkina via llvm-dev
>> >> Sent: Friday, July 15, 2016 6:05 AM
>> >> To: llvm-dev
>> >> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements
>> >>
>> >> Hi all,
>> >>
>> >> Now all discussed enhancements are divided into separate patches.
>> >> Moreover I have found mistake which reduces performance. Now it's
>> fixed.
>> >>
>> >> List of patches (for those interested):
>> >> Repeats in regular expressions - https://reviews.llvm.org/D22342
>> >> Including files - https://reviews.llvm.org/D22344
>> >> Expressions repeat for CHECK and CHECK-NEXT -
>> >> https://reviews.llvm.org/D22345
>> >> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348
>> >> CHECK-WORD - https://reviews.llvm.org/D22353
>> >> prefixes-regular expressions - https://reviews.llvm.org/D22401
>> >> pattern templates - https://reviews.llvm.org/D22403.
>> >>
>> >> Thanks,
>> >> Elena.
>> >> _______________________________________________
>> >> LLVM Developers mailing list
>> >> llvm-dev at lists.llvm.org
>> >> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>> > _______________________________________________
>> > LLVM Developers mailing list
>> > llvm-dev at lists.llvm.org
>> > http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>>
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160718/a56e1376/attachment.html>


More information about the llvm-dev mailing list