[llvm-dev] RFC: FileCheck Enhancements

[Vedant Kumar via llvm-dev]

> On Jul 15, 2016, at 5:36 PM, Mehdi Amini via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
>> On Jul 15, 2016, at 8:58 AM, Robinson, Paul via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> 
>> Please add llvm-commits as a subscriber to all of these reviews
>> so everyone has a chance to see/comment on them.
> 
> Adding llvm-commits after the fact ends up in the mailing list not archiving the context of the reviews.
> If these patches are fresh (no significant review occurred), they should be closed and new revisions need to be opened, with llvm-commits as a subscriber from the start.

Ah, oops. I've started reviews of a few of the patches. If you plan on re-creating the reviews, please mark the relevant in-line comments on these as "Done" so it's easier to track what's changed: D22353, D22403, D22344.

thanks
vedant


> 
> 
> — 
> Mehdi
> 
> 
>> Thanks,
>> --paulr
>> 
>>> -----Original Message-----
>>> From: llvm-dev [mailto:llvm-dev-bounces at lists.llvm.org] On Behalf Of Elena
>>> Lepilkina via llvm-dev
>>> Sent: Friday, July 15, 2016 6:05 AM
>>> To: llvm-dev
>>> Subject: Re: [llvm-dev] RFC: FileCheck Enhancements
>>> 
>>> Hi all,
>>> 
>>> Now all discussed enhancements are divided into separate patches.
>>> Moreover I have found mistake which reduces performance. Now it's fixed.
>>> 
>>> List of patches (for those interested):
>>> Repeats in regular expressions - https://reviews.llvm.org/D22342
>>> Including files - https://reviews.llvm.org/D22344
>>> Expressions repeat for CHECK and CHECK-NEXT -
>>> https://reviews.llvm.org/D22345
>>> CHECK-LABEL-DAG - https://reviews.llvm.org/D22348
>>> CHECK-WORD - https://reviews.llvm.org/D22353
>>> prefixes-regular expressions - https://reviews.llvm.org/D22401
>>> pattern templates - https://reviews.llvm.org/D22403.
>>> 
>>> Thanks,
>>> Elena.
>>> _______________________________________________
>>> LLVM Developers mailing list
>>> llvm-dev at lists.llvm.org
>>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
>> _______________________________________________
>> LLVM Developers mailing list
>> llvm-dev at lists.llvm.org
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev