[llvm-dev] Is there a reason why MCAsmStreamer class doesn't have its own .h file?

Thu Jan 21 22:09:47 PST 2016

> On Jan 21, 2016, at 14:42, Rail Shafigulin via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
> Does anybody know if there is a particular reason why MCAsmStreamer doesn't have its own .h file? 
> 
> https://github.com/llvm-mirror/llvm/blob/0e66a5f53c74056f95d178c86531d7d9cfb23da9/lib/MC/MCAsmStreamer.cpp#L41 <https://github.com/llvm-mirror/llvm/blob/0e66a5f53c74056f95d178c86531d7d9cfb23da9/lib/MC/MCAsmStreamer.cpp#L41>
> 
> It seems like it is a good idea to have this class declared as its own module ( its own .cpp and .h files). That would make it easier to inherit from it if there is a need (like in my current case). 
> 
> Any help is appreciated.
> 
> -- 
> Rail Shafigulin
> Software Engineer 
> Esencia Technologies
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev

I have patches to move parts of it to a header:

http://reviews.llvm.org/D11822 <http://reviews.llvm.org/D11822>
http://reviews.llvm.org/D11823 <http://reviews.llvm.org/D11823>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160121/87a9af04/attachment.html>