[llvm-dev] Phabricator/Arcanist feedback

[Mehdi Amini via llvm-dev]

> On Jan 8, 2016, at 8:04 AM, Simon Taylor via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
>> On 8 Jan 2016, at 15:43, Krzysztof Parzyszek via llvm-dev <llvm-dev at lists.llvm.org> wrote:
>> 
>> On 1/8/2016 9:39 AM, Joerg Sonnenberger via llvm-dev wrote:
>>> 
>>> Huh? Under "Leap into action" on the bottom of the page, there is "Close
>>> revision".
>> 
>> Hmm.  Indeed.  I don't know why I didn't notice it before.  Oh well, today I learned…
> 
> If it’s a revision authored by someone else (even if you are a reviewer), the “Close” doesn’t appear - it’s necessary to first “Comandeer Revision” before the close option shows up. I’ve been confused by that in the past on other projects using Phabricator.

I think you can close even if you are not the author (I did it multiple times), but the revision has to be “Accepted” first.

— 
Mehdi