[llvm-dev] Question about __NSConstantString and __NSConstantString_tag

[Brad King via llvm-dev]

On 02/19/2016 10:35 AM, Ben Langmuir wrote:
>> On Feb 19, 2016, at 7:16 AM, Brad King wrote:
>> [snip]
>>> __NSConstantString and __NSConstantString_tag are now exposed.
>> To clarify, this is not so much about the appearance of new builtins
>> but that the structure has fields with no name.  Other builtin
>> structures like __va_list_tag have names on their fields.  FieldDecl
>> derives (indirectly) from NamedDecl.
>>
>> Our concern is that AST processing tools expect to find a name on
>> fields, and the changes in question introduced fields without names.
>> Can they be given names, if only for AST consistency?
> 
> Yes, sounds like a good idea. I’ll take a look at this later today.

Here is a patch that adds the field names.

Thanks,
-Brad

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Populate-field-names-on-builtin-struct-underlying-__.patch
Type: text/x-diff
Size: 1831 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160225/7340db07/attachment.patch>