[llvm-dev] Heap problems with 3.8.0rc2 in combination with vs2015 sp1

Thu Feb 25 04:07:17 PST 2016

I made the llvm::Function() constructor public (for testing purpose) and
used the non-overloaded new.

auto func = ::new llvm::Function(...)
if (func) func->eraseFromParent();

And the heap corruption is gone! Did something changed in llvm::User::new
between 3.7.1 and 3.8.0 ?
I found a bug in llvm ?

On Thu, Feb 25, 2016 at 12:10 PM, koffie drinker <gekkekoe at gmail.com> wrote:

> I downloaded 3.8.0rc3 and I also have it in 3.8.0rc3.
> I did set a data access breakpoint on the first function ptr that causes
> the invalid heap. This would allow me to break whenever someone is touching
> that address. It did not show double deletes during debugging. Further more
> I managed to narrow it down to 2 function calls:
>
> // stupid code, but its just for triggering heap error
> auto func = llvm::Function::Create(...);
> if (func) func->eraseFromParent();
>
> The erase from parent triggers the invalid heap. I used appverif.exe and
> gflags.exe (page heap checks) but they could not find anything.
> The Function::Create is just a wrapper for new Function(). I also traced
> into this call, but did not see anything weird. It returns a valid ptr.
> Somehow the ptr returned by the new seems to be broken. If i'm not
> mistaken the new operator is overloaded by llvm? I could not try to use the
> default new Function() since its constructor is not accessible from outside.
>
> I'm kinda lost where to look next. There's not much that could go wrong
> with creating a function and deleting it?
> I'm using visual studio 2015 update1, and could not find any known issue
> regarding heaps. I'm at a point where I'm suspecting my compiler.
> But its weird that the same compiler works fine with 3.7.1
>
> any ideas would be appreciated
>
>
> On Wed, Feb 24, 2016 at 9:10 AM, koffie drinker <gekkekoe at gmail.com>
> wrote:
>
>>
>> I recently upgraded from llvm 3.7.1 to a pre release of llvm (3.8.0rc2)
>> in order to test some issues regarding bug 24233.
>> After upgrading I starting to see heap corruption messages in vs 2015 sp1
>> when my program exits.
>> "HEAP[ConsoleEngine.exe]: Invalid address specified to RtlValidateHeap(
>> 0000000000290000, 0000000000318698 )"
>>
>> Initially I only got it in Release build. Debug build seems to be fine,
>> but recently I also got them in Debug build.
>> I traced it down how to trigger it in Debug Mode. It happens when I put
>> the ExecutionEngine creation in the constructor in the cpp file.
>> If I put it in the h file then there's no problem. This leads me to
>> believe that it is probably not my code that is causing it since I never
>> seem to have
>> this issue in the past (3.6.x - 3.7.x). I've include the stack traces
>> below this email.
>>
>> It fails when the dtor is called for the first module. MCJIT only has 2
>> modules, the first one only has function declarations. The second one is
>> empty. No codegen is taking place.
>>
>> I googled for the error message and it seems to be happen when you delete
>> a resource twice.
>> Did something change for 3.8.0 regarding to function decl. creation in a
>> module? Any tips on how to trace it down further? I can't seem to make a
>> small example demonstration the problem. It only seems to be triggered in a
>> larger project (again: nearly code works fine in 3.6.x-3.7.x)
>>
>>
>> -- Release mode stack trace
>>   ntdll.dll!RtlReportCriticalFailure() Unknown
>>   ntdll.dll!RtlpReportHeapFailure() Unknown
>>   ntdll.dll!RtlpHeapHandleError() Unknown
>>   ntdll.dll!RtlpLogHeapFailure() Unknown
>>   ntdll.dll!string "Enabling heap debug options\n"() Unknown
>>   ucrtbase.dll!free() Unknown
>>   ConsoleEngine.exe!llvm::Function::`vector deleting
>> destructor'(unsigned int) C++
>>   ConsoleEngine.exe!llvm::Module::~Module(void) C++
>>   ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(class
>> llvm::SmallPtrSet<class llvm::Module *,4> &) C++
>>   ConsoleEngine.exe!llvm::MCJIT::~MCJIT(void) C++
>>   ConsoleEngine.exe!llvm::MCJIT::`vector deleting destructor'(unsigned
>> int) C++
>>
>> -- Debug Mode stack trace
>> ntdll.dll!RtlpBreakPointHeap() Unknown
>>   ntdll.dll!string "Enabling heap debug options\n"() Unknown
>>   ntdll.dll!RtlValidateHeap() Unknown
>>   KernelBase.dll!HeapValidate() Unknown
>>   ucrtbased.dll!_CrtIsValidHeapPointer() Unknown
>>   ucrtbased.dll!_calloc_base() Unknown
>>   ucrtbased.dll!_free_dbg() Unknown
>>   ConsoleEngine.exe!operator delete(void * block) Line 21 C++
>> ConsoleEngine.exe!llvm::User::operator delete(void * Usr) Line 195 C++
>>   ConsoleEngine.exe!llvm::Function::`scalar deleting
>> destructor'(unsigned int) C++
>>   ConsoleEngine.exe!llvm::ilist_node_traits<llvm::Function>::deleteNode(llvm::Function
>> * V) Line 160 C++
>>   ConsoleEngine.exe!llvm::iplist<llvm::Function,llvm::SymbolTableListTraits<llvm::Function>
>> >::erase(llvm::ilist_iterator<llvm::Function> where) Line 519 C++
>>   ConsoleEngine.exe!llvm::iplist<llvm::Function,llvm::SymbolTableListTraits<llvm::Function>
>> >::erase(llvm::ilist_iterator<llvm::Function> first,
>> llvm::ilist_iterator<llvm::Function> last) Line 601 C++
>>   ConsoleEngine.exe!llvm::iplist<llvm::Function,llvm::SymbolTableListTraits<llvm::Function>
>> >::clear() Line 605 C++
>>   ConsoleEngine.exe!llvm::Module::~Module() Line 61 C++
>>   ConsoleEngine.exe!llvm::Module::`scalar deleting destructor'(unsigned
>> int) C++
>>   ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::freeModulePtrSet(llvm::SmallPtrSet<llvm::Module
>> *,4> & MPS) Line 175 C++
>>   ConsoleEngine.exe!llvm::MCJIT::OwningModuleContainer::~OwningModuleContainer()
>> Line 82 C++
>>   ConsoleEngine.exe!llvm::MCJIT::~MCJIT() Line 102 C++
>>   ConsoleEngine.exe!llvm::MCJIT::`scalar deleting destructor'(unsigned
>> int) C++
>>   ConsoleEngine.exe!std::default_delete<llvm::ExecutionEngine>::operator()(llvm::ExecutionEngine
>> * _Ptr) Line 1195 C++
>>   ConsoleEngine.exe!std::unique_ptr<llvm::ExecutionEngine,std::default_delete<llvm::ExecutionEngine>
>> >::~unique_ptr<llvm::ExecutionEngine,std::default_delete<llvm::ExecutionEngine>
>> >() Line 1398 C++
>>
>>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160225/e888d1f1/attachment.html>