[llvm-dev] visitShiftByConstant of DAGCombiner

[Renato Golin via llvm-dev]

On 19 December 2016 at 09:58, Jojo Ma <jojo.ma at linaro.org> wrote:
> /home/likewise-open/SPREADTRUM/jojo.ma/jojoma/source/llvm/llvm-linaro/llvm/llvm/test/CodeGen/Thumb2/machine-licm.ll:88:10:
> error: expected string not found in input
> ; CHECK: movw {{(r[0-9])|(lr)}}, #32768
>          ^
> <stdin>:56:2: note: scanning from here
>  movw r12, #32768
>  ^

Hi Jojo,

This is just a bad check line. :)

Instead of:

; CHECK: movw {{(r[0-9])|(lr)}}, #32768

it should have been:

; CHECK: movw {{(r[0-9]+)|(lr)}}, #32768

(ie. add the extra '+' at the end, so you allow more than one number).

If that's the last remaining problem, I suggest you fix the CHECK
line, create the tests necessary to test your pass, and make sure that
the LICM code makes sense (it doesn't look worse to me, but the
instructions are different, just need to make sure they have the same
semantics).

cheers,
--renato