[llvm-dev] RFC: Constructing StringRefs at compile time

Zachary Turner via llvm-dev llvm-dev at lists.llvm.org
Mon Dec 12 14:16:34 PST 2016


Review up here: https://reviews.llvm.org/D27686

I only added 2 people as reviewers, but since many people had comments on
this thread, feel free to comment on the review if this interests you.

On Mon, Dec 12, 2016 at 1:02 PM Zachary Turner <zturner at google.com> wrote:

> Well, apparently clang has clang::StringLiteral in clang/AST/Expr.h
>
> So, our options are either: Allow this name clash (obviously the
> namespaces don't clash, only the names) and deal with it when it's an issue
> (which will be limited to clang, and even then not very often), or choose a
> different name.
>
> Thoughts?
>
> On Mon, Dec 12, 2016 at 11:53 AM Zachary Turner <zturner at google.com>
> wrote:
>
> I can. I'll whip something up today
> On Fri, Dec 9, 2016 at 1:18 AM Malcolm Parsons <malcolm.parsons at gmail.com>
> wrote:
>
> On 2 December 2016 at 17:12, James Y Knight <jyknight at google.com> wrote:
> > +1 from me for the StringLiteral proposal from a few messages back.
>
> Zachary, do you want to commit StringLiteral?
>
> --
> Malcolm Parsons
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20161212/cf150890/attachment.html>


More information about the llvm-dev mailing list