[llvm-dev] [RFC] RISC-V backend

Renato Golin via llvm-dev llvm-dev at lists.llvm.org
Wed Aug 17 13:11:58 PDT 2016


On 17 August 2016 at 20:39, Mehdi Amini via llvm-dev
<llvm-dev at lists.llvm.org> wrote:
> Aren’t code owner supposed to help find reviewers?
> From the developer policy: "The sole responsibility of a code owner is to
> ensure that a commit to their area of the code is appropriately reviewed,
> either by themself or by someone else.“

Then you fall into the problem of finding the right code owner to
review. A new back-end falls into a multitude of domains, most of them
with different code owners, some of them without any (citation
needed).

Another issue is what I mention in the "new targets policy" as the
maturing process. Reviewing a patch into an existing piece of code is
orders of magnitude simpler than reviewing a whole new target, and
code owners may feel entirely incompetent to review code that they
have no idea how it should work (haven't read the ISA/ABI documents,
doesn't know the target, etc).

It boils down to nagging from the people who proposed the patch/es in
the first place, as was repeatedly mentioned in the target acceptance
and developer policies discussions of the past.

Many of us have limited attention span... (squirrel!).

cheers,
--renato


More information about the llvm-dev mailing list