[llvm-dev] LTO and intrinsics mangling
Philip Reames via llvm-dev
llvm-dev at lists.llvm.org
Mon Apr 18 16:25:47 PDT 2016
On 04/18/2016 09:52 AM, Mehdi Amini via llvm-dev wrote:
>>
>> Initially I came across the problem with my recent change which added
>> an overloaded type to the masked load/store intrinsics
>> (http://reviews.llvm.org/D17270). The discrepancy between the name
>> and the signature triggers auto-upgrade bit from my patch converting
>> an incorrect mangling to the correct one. But later after remapping
>> of isomorphic types when we return to the original type name this
>> “updated" intrinsic name become invalid.
>
> In the same way, I'd try to avoid "autoupgrading" in this case? I'm
> puzzled by the fact that round-tripping to bitcode within the same
> version of LLVM triggers an "upgrade".
This does seem questionable. It's doesn't avoid the root issue - which
is that we're not renaming intrinsics when renaming types - but changing
this would seem reasonable to me. It sounds like we might be relying on
the upgrade functionality to paper over problems with type renaming.
(And possibly other things...?)
Philip
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20160418/860b2227/attachment.html>
More information about the llvm-dev
mailing list