[llvm-dev] LibC++ tests in tree

[Renato Golin via llvm-dev]

On 8 September 2015 at 16:35, Jonathan Roelofs
<jonathan at codesourcery.com> wrote:
> I think that adding such a symlink breaks multiarch installs... Rhetorically
> speaking, what arch would `lib/clang/3.8.0/linux/librt.a` support for a
> compiler with more than one backend included?

It seems -lrt wasn't related to compiler-rt after all. But if it were,
I'd say the installation process should understand the difference
between host and target, multilib and multiarch.

Right now, the option --rtlib is doing nothing useful, but it could
also, from the triple, find the right lib and link to it
automatically.


> One thing to note about this locale detection stuff is that it relies on
> testing for the locales from python, which might give different results than
> via c++ (I don't know of an example of this, but it could be plausible).

I'd expect the C++ library to also have some detection mechanism, at
least to show that error message.


> The other caveat is that the locale detection happens on $host, but the
> actual tests could be running on $target. If $host != $target, then
> detecting it in python is almost definitely the wrong thing to do.

The detection could be in the test itself, as a prepare task before
running, in the C++ code, so that it executed on the same target as
the tests themselves.

cheers,
--renato