[llvm-dev] Prefixing DEBUG messages with DEBUG_TYPE (was re: [PATCH] D13259: LLE 6/6: Add LoopLoadElimination pass)

[Matthias Braun via llvm-dev]

Well no strong opposition here, if the prefixes help you go ahead and introduce them. I just wanted to make sure we have considered the no-prefix option.

- Matthias

> On Nov 2, 2015, at 11:29 AM, Hal Finkel <hfinkel at anl.gov> wrote:
> 
> ----- Original Message -----
>> From: "Renato Golin" <renato.golin at linaro.org>
>> To: "Hal Finkel" <hfinkel at anl.gov>
>> Cc: "Matthias Braun" <mbraun at apple.com>, "llvm-dev" <llvm-dev at lists.llvm.org>
>> Sent: Monday, November 2, 2015 1:24:16 PM
>> Subject: Re: [llvm-dev] Prefixing DEBUG messages with DEBUG_TYPE (was re: [PATCH] D13259: LLE 6/6: Add
>> LoopLoadElimination pass)
>> 
>> On 2 November 2015 at 19:19, Hal Finkel via llvm-dev
>> <llvm-dev at lists.llvm.org> wrote:
>>> I generally find the prefixes convenient when searching the debug
>>> output for debug messages from a particular pass.
>> 
>> Especially when you enable debug for all passes as well as
>> print-after-all.
> 
> I'll add that this is particularly important when, for example, debug messages from different passes appear intermingled. This is common for lazy analysis passes (such as SCEV).
> 
> -Hal
> 
>> 
>> --renato
>> 
> 
> -- 
> Hal Finkel
> Assistant Computational Scientist
> Leadership Computing Facility
> Argonne National Laboratory