[LLVMdev] Code Owner for OpenMP (runtime)

Chandler Carruth chandlerc at google.com
Fri May 1 10:41:52 PDT 2015


On Fri, May 1, 2015 at 2:11 AM Andrey Bokhanko <andreybokhanko at gmail.com>
wrote:

> All,
>
> Chris Bergström and Chandler Carruth made code ownership-related
> comments in another thread
> (http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-April/085068.html);
> let me answer on them here:
>
> Chris wrote:
> > To stay more agnostic I'd love to see a non-Intel owner. While Hal may
> > not be the most active contributor - his reviews are invaluable and
> > less biased. I don't know if Hal has the time or interest, but I'd
> > nominate him for "owner". I see Tom wants to assign more owners, but
> > I'd like to avoid this being an "Intel runtime owned and controlled by
> > Intel"
>
> Chandler wrote:
> > - I agree with finding some non-Intel folks to add as explicit code
> owners.
> > I don't know who has been sufficiently involved, but if Hal makes sense,
> > awesome.
>
> While I'm always happy to see more maintainers (which means better
> chance to get code reviewed!) and Hal is an all-around good guy, this,
> IMHO, sets a bad and dangerous precedent.
>

After more thought, I agree.

I wrote this off the cuff in the spirit of "if code owners being too narrow
are presenting problems, lets find more code owners!", not with any real
feeling that this was important or necessary. And I agree with your points
about it being bad.

I also skimmed through several months worth of development mail and
completely agree with Andrey Churbanov being the only realistic code owner.
=] However, I've not heard from him here? He should at least be part of the
discussion! ;]

Anyways, sorry that my minor comment caused such frustration for folks, I
wish it hadn't, as I didn't mean it in a strong or imperative way, and
actually agree with all of the concerns.

Let's get back to the technical side of getting things ready to flip over.

-Chandler
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150501/c5a09493/attachment.html>


More information about the llvm-dev mailing list