[LLVMdev] Code Owner for OpenMP (runtime)

[Andrey Bokhanko]

All,

Chris Bergström and Chandler Carruth made code ownership-related
comments in another thread
(http://lists.cs.uiuc.edu/pipermail/llvmdev/2015-April/085068.html);
let me answer on them here:

Chris wrote:
> To stay more agnostic I'd love to see a non-Intel owner. While Hal may
> not be the most active contributor - his reviews are invaluable and
> less biased. I don't know if Hal has the time or interest, but I'd
> nominate him for "owner". I see Tom wants to assign more owners, but
> I'd like to avoid this being an "Intel runtime owned and controlled by
> Intel"

Chandler wrote:
> - I agree with finding some non-Intel folks to add as explicit code owners.
> I don't know who has been sufficiently involved, but if Hal makes sense,
> awesome.

While I'm always happy to see more maintainers (which means better
chance to get code reviewed!) and Hal is an all-around good guy, this,
IMHO, sets a bad and dangerous precedent.

If code ownership for libiomp by someone employed by Intel means
"Intel runtime owned and controlled by Intel", then why ownership of
libc++ by Marshall Clow (from Qualcomm) is not judged on the same
grounds ("Qualcomm runtime owned and controlled by Qualcomm")? Same
for LLDB (owned by Greg Clayton from Apple), Sanitizers (owned by
Kostya and Evgeniy Stepanov, both from Google), etc, etc?

This simply goes against the basic principle of open-source
development: the person who wrote most of the code / most active in
development recently is the natural choice for code ownership. His/her
affiliation is not relevant at all. To have this rule broken
specifically for Intel is quite amusing, to say the least.

Also, in the very same message, Chris wrote:

> It doesn't really feel that way. I proposed a cmake patch and the only
> person to review or comment was Intel. (This is coming from the person
> who ported it to ARM)

So, Chris submitted a patch and this patch got reviewed by someone
from Intel and nobody else. By definition, this Intel person served as
a good code owner. What's the problem with this and what outcome Chris
expected -- his patch to be NOT reviewed?!

To finish this rant, let's give Andrey Churbanov a chance and judge
him as everyone else being judged here -- by his own merits. So far he
did very well! -- I challenge everyone to present a single example of
getting bad treatment from Andrey ("Speak now or forever hold your
peace", or so they say... :-))

Yours,
Andrey Bokhanko
=============
Software Engineer
Intel Compiler Team
Intel

On Thu, Apr 30, 2015 at 4:44 PM, Tom Stellard <tom at stellard.net> wrote:
> On Thu, Apr 30, 2015 at 11:59:52AM +0100, Renato Golin wrote:
>> Tom, code owner nomination.
>>
>> Andrey is the most active developer, so I think it makes sense. How
>> long do we wait to change the file? Is there any process that you'd
>> like to follow?
>>
>
> I don't think there is a formal process, but usually the file gets
> updated once Chris approves.
>
> -Tom
>
>> cheers,
>> --renato
>>
>> On 30 April 2015 at 10:03, Cownie, James H <james.h.cownie at intel.com> wrote:
>> > We have noticed that although we have active development in the OpenMP
>> > runtime, there is no formal code-owner.
>> >
>> >
>> >
>> > I would therefore like to nominate Andrey Churbanov who is a major committer
>> > and has deep experience with the runtime code since before it was the LLVM
>> > runtime.
>> >
>> >
>> >
>> > -- Jim
>> >
>> > James Cownie <james.h.cownie at intel.com>
>> > SSG/DPD/TCAR (Technical Computing, Analyzers and Runtimes)
>> >
>> > Tel: +44 117 9071438
>> >
>> >
>> >
>> > ---------------------------------------------------------------------
>> > Intel Corporation (UK) Limited
>> > Registered No. 1134945 (England)
>> > Registered Office: Pipers Way, Swindon SN3 1RJ
>> > VAT No: 860 2173 47
>> >
>> > This e-mail and any attachments may contain confidential material for
>> > the sole use of the intended recipient(s). Any review or distribution
>> > by others is strictly prohibited. If you are not the intended
>> > recipient, please contact the sender and delete all copies.
>> >
>> >
>> > _______________________________________________
>> > LLVM Developers mailing list
>> > LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> > http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>> >
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev