[LLVMdev] Long-Term Support for LLVM Projects Extension to Build System?

[John Criswell]

Dear All,

Thanks for the feedback.

To clarify, this is for LLVM-related projects that are linking against 
the LLVM libraries.

The feature for keeping our source code in arbitrary locations isn't 
something we need.  If we can just drop our source code into 
llvm/projects (or some other designated LLVM subdirectory) and write 
LLVM-esque CMake files, that should be enough for projects that don't 
need to patch the existing LLVM tools.

Regards,

John Criswell


On 6/18/15 9:06 PM, Chandler Carruth wrote:
> On Thu, Jun 18, 2015 at 5:50 PM Hal Finkel <hfinkel at anl.gov 
> <mailto:hfinkel at anl.gov>> wrote:
>
>     This is also related to the metapoint that the cmake build system
>     doesn't glob for source files (or anything else), unlike the
>     makefile build system. This is understandable given the
>     constraints, but we might want to restore some of that
>     functionality for the purpose of supporting out-of-tree projects.
>
>
> I actually think these are completely separate. See below.
>
>
>     What I mean specifically, is that, for example, we could have a
>     normally-empty directory tools/extensions, and
>     tools/CMakeLists.txt could glob for directories in
>     tools/extensions and call add_llvm_tool_subdirectory on all of
>     them. It is true that you'd need to re-run cmake whenever you
>     added something there (we could have a README in that directory to
>     remind people of that), but that seems like a much smaller price
>     than having to maintain a patched version of the upstream sources.
>
>
> We already do this in numerous places. See projects/CMakeLists.txt 
> which does exactly this.
>
> We don't automatically support external projects *in different 
> locations* through globbing, but that's because that doesn't make any 
> sense.
>
> We can add globbing-based recursion to subproject CMake files anywhere 
> it is useful.
>
> There is no problem with globbing to add subdirectories IMO because 
> subdirectories *with new CMake files* clearly have to be introduced 
> and maintained at the points you run the 'cmake' tool. Only globbing 
> for *source files* seems problematic to me at all.
>
> -Chandler
>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev


-- 
John Criswell
Assistant Professor
Department of Computer Science, University of Rochester
http://www.cs.rochester.edu/u/criswell

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150619/852f01e8/attachment.html>