[LLVMdev] Clang-Format all LLVM Projects

Jeremy Lakeman Jeremy.Lakeman at gmail.com
Fri Jun 12 19:42:15 PDT 2015


There's probably a way to abuse the -textconv argument to git
(diff|blame)...

On Sat, Jun 13, 2015 at 11:47 AM, Saleem Abdulrasool <compnerd at compnerd.org>
wrote:

> On Sun, Jun 7, 2015 at 9:59 AM, Renato Golin <renato.golin at linaro.org>
> wrote:
>
>> On 7 June 2015 at 14:51, Peet <mezo37 at yandex.com> wrote:
>> > I would like to ask if it is worth a shot to create a pull request
>> which basically clang-formats projects like libcxxabi/libunwind ?
>> > Since those projects aren't following the LLVM coding standards.
>> > It would make the code even "more readable" also it would give "me" the
>> feeling that it actually belongs to the LLVM project.
>>
>> Hi Peet,
>>
>> We had this discussion a number of times for different projects and
>> the general feeling was that it wouldn't be a big problem to do so,
>> but that also depends on the project's community. I'm copying some of
>> the main developers of those projects for their view on the matter.
>>
>> I personally prefer not to format code that hasn't changed, as that
>> messes up with the version history (git blame and all), but people are
>> normally less paranoid than I am.
>>
>
> Normally, I would agree.  However, unless Im mistaken, the splitting of
> libunwind did destroy history :-(.  In that case, unless there are
> objections from others (I think Nick should be included in this set), I
> don't think we loose too much in the specific case of libunwind.   But, I
> agree in the case of libc++/libc++abi.
>
>
>> cheers,
>> --renato
>>
>
> --
> Saleem Abdulrasool
> compnerd (at) compnerd (dot) org
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150613/1e1dbc57/attachment.html>


More information about the llvm-dev mailing list