[LLVMdev] Who to assign as "reviewers" for a patch??

[mats petersson]

Yes, if you run "git blame" or "svn blame" (whichever you are using) on the
file, and find who was last updating the part of the file you are
modifying, then you may have a good candidate to who to review it. However,
I believe you should also add the overall owner of that code, so that the
owner is a) aware of your changes and b) can take a "big picture view" of
the changes (you may be doing the right thing, but some subtle difference
may help make the code more suitable for future changes, etc).

--
Mats

On 5 June 2015 at 11:32, Yaron Keren <yaron.keren at gmail.com> wrote:

> You can also look for people patching CFI- or X86- related code.
>
> 2015-06-05 13:11 GMT+03:00 Neil Henning <llvm at duskborn.com>:
>
>>  Look at the CODE_OWNERS.txt file, find the places your patch touches and
>> who owns them, add those people to the review. At least that's what I've
>> been told previously when submitting patches.
>>
>> -Neil.
>>
>>
>> On 05/06/15 10:54, Alex wrote:
>>
>> Dear LLVM devs,
>>
>>  I just submitted a patch: http://reviews.llvm.org/D10149
>> <https://urldefense.proofpoint.com/v2/url?u=http-3A__reviews.llvm.org_D10149&d=AwMFaQ&c=8hUWFZcy2Z-Za5rBPlktOQ&r=Mfk2qtn1LTDThVkh6-oGglNfMADXfJdty4_bhmuhMHA&m=nZZqzbxhY7-xAfSiCDcR2N_iD2VxcU1KAZOU2nmF-50&s=cp7ZvsQqW1U9EYlIGQEAvE8Nmp1zXoM8rF3cezzN7IM&e=>.
>> However, Phabricator is warning me that "this revision needs review, but
>> there are no reviewers specified".
>>
>>  How should I determine who the reviewers should be?
>>
>>  Thanks,
>> Alex Dowad
>>
>>
>> _______________________________________________
>> LLVM Developers mailing listLLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.eduhttp://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>>
>>
>> _______________________________________________
>> LLVM Developers mailing list
>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>>
>>
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150605/ee11ac42/attachment.html>