[LLVMdev] SelectionDAG viewers, filter-view-dags question

[Daniel Sanders]

I've just looked at my checkout of 3.6 and it looks like the fix wasn't merged. I don't have the revision number for the fix to hand but in lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp, this:
  MatchFilterBB = (!FilterDAGBasicBlockName.empty() &&
                   FilterDAGBasicBlockName ==
                       FuncInfo->MBB->getBasicBlock()->getName().str());
Should be:
  MatchFilterBB = (FilterDAGBasicBlockName.empty() ||
                   FilterDAGBasicBlockName ==
                       FuncInfo->MBB->getBasicBlock()->getName().str());

The trunk has the correct code so the option should be ok for LLVM 3.7.

From: Ryan Taylor [mailto:ryta1203 at gmail.com]
Sent: 27 July 2015 17:20
To: Daniel Sanders
Cc: llvmdev at cs.uiuc.edu
Subject: Re: [LLVMdev] SelectionDAG viewers, filter-view-dags question

Daniel,

  We are using 3.6. Someone also pointed out that it was mandatory in 3.6.2 but I have not verified that.


On Mon, Jul 27, 2015 at 12:10 PM, Daniel Sanders <Daniel.Sanders at imgtec.com<mailto:Daniel.Sanders at imgtec.com>> wrote:
It's not supposed to be. There was a short period where it was unintentionally mandatory but this was fixed after I pointed it out during post-commit review.

Which version/revision are you using?

From: llvmdev-bounces at cs.uiuc.edu<mailto:llvmdev-bounces at cs.uiuc.edu> [mailto:llvmdev-bounces at cs.uiuc.edu<mailto:llvmdev-bounces at cs.uiuc.edu>] On Behalf Of Ryan Taylor
Sent: 27 July 2015 16:27
To: llvmdev at cs.uiuc.edu<mailto:llvmdev at cs.uiuc.edu>
Subject: [LLVMdev] SelectionDAG viewers, filter-view-dags question

Is this option currently mandatory? If so, why? If not, I'm not sure what's been added that I need to do differently.

-view-isel-dags opened just fine in dotty in 3.4 and now this does nothing without the filter-view-dags 'option' and now has a different priority program list or something.

I'm just curious why this option should be mandatory?

Thanks.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150727/ce1fc8d8/attachment.html>