[LLVMdev] Should I commit "IR: Move MDLocation into place" before or after 3.6 branch?

[Adrian Prantl]

One small request: Omitting the column field from MDLocation if it is 0 is fine, because it won’t make it into the line table. Omitting the line if it is 0 is not, because it gives the wrong impression that the line is being ignored, which is not the case. Line 0 will be emitted in the line table and has special semantics (Line 0 in DWARF may be used to mark compiler-generated code that has no corresponding source line number).

thanks,
adrian

> On Jan 13, 2015, at 9:46 PM, Duncan P. N. Exon Smith <dexonsmith at apple.com> wrote:
> 
> I just finished the work for PR21433.  I think it's relatively low risk,
> but it does change assembly output.
> 
> Should I commit this before or after the (imminent) 3.6 branch?
> 
> (I would have committed it tonight, but the buildbots are fairly red,
> and I prefer to break out-of-tree code in the morning anyway.)
> 
> <llvm.patch><clang.patch>