[LLVMdev] LLD Standalone CMake build

Greg Fitzgerald garious at gmail.com
Mon Jan 12 16:07:26 PST 2015


> * fix the coding style first.
> * check-all clean on a asan and msan build.
> * -DBUILD_SHARED_LIBS=ON works.

I can take the ASan/MSan and build work.  Fixing the coding style is
important, but must it be a gate?  If so, can we push the patch for
lowerCamelCase local variables in the LLVM coding conventions before
there's a plan on how to transition the LLVM codebase?

Thanks,
Greg



On Fri, Jan 9, 2015 at 4:22 PM, Rafael EspĂ­ndola
<rafael.espindola at gmail.com> wrote:
> On 8 January 2015 at 19:46, Chandler Carruth <chandlerc at google.com> wrote:
>>
>> On Thu, Jan 8, 2015 at 4:35 PM, Greg Fitzgerald <garious at gmail.com> wrote:
>>>
>>> How do you feel about adding LLD to the LLVM repo?  Could it follow
>>> the same path as the integrated assembler?  That is, Clang keeps it
>>> off by default for each architecture until it's ready for prime time.
>>
>>
>> While I'm not personally opposed to it, I think it's reasonable to avoid if
>> people want to not have the clutter of a linker when checking out and using
>> LLVM.
>
> If this ever happens, we *must* fix the coding style first. I would
> also list as must fix before:
>
> * check-all clean on a asan and msan build.
> * -DBUILD_SHARED_LIBS=ON works.
>
> Cheers,
> Rafael




More information about the llvm-dev mailing list