[LLVMdev] [PATCH 2/2 v3] add visibility hidden to tls entry points

[Marc Dietrich]

Am Dienstag, 17. Februar 2015, 13:13:28 schrieb Sedat Dilek:
> On Tue, Feb 17, 2015 at 12:38 PM, Marc Dietrich <marvin24 at gmx.de> wrote:
> > Am Dienstag, 17. Februar 2015, 11:58:06 schrieb Sedat Dilek:
> >> On Tue, Feb 17, 2015 at 10:40 AM, Marc Dietrich <marvin24 at gmx.de> wrote:
> >> > Avoid redefined symbol errors in clang. Based on a suggestion from
> >> > Rafael Ávila de Espíndola <rafael.espindola at gmail.com> in
> >> > http://llvm.org/bugs/show_bug.cgi?id=19778.
> >> > 
> >> > Signed-off-by: Marc Dietrich <marvin24 at gmx.de>
> >> > ---
> >> > v2: - no change
> >> > v3: - include util directory in Makefile.am in order to avoid relative
> >> > 
> >> >       include paths,
> >> >     
> >> >     - make tls entry points array const
> >> 
> >> I adapted this patch as v4 to fit mesa v10.4.4, but it fails (see
> >> log-file in attached tarball).
> > 
> > the configure output says that visibility is not supported by your clang.
> > Interestingly, it is supported here (also clang 3.6 from yesterday). What
> > does config.log say about it?
> 
> Here is my config.log.
> 
> $ grep -i visibility config.log
> configure:18401: checking for __attribute__((visibility))
> ax_cv_have_func_attribute_visibility=no
> VISIBILITY_CFLAGS=''
> VISIBILITY_CXXFLAGS=''

the problem here is that you are using "-v" flag which generates some warning 
output. The result is that *all* attribute detection fails. Remove it and try 
again.

Marc
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 473 bytes
Desc: This is a digitally signed message part.
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150217/d145f5c1/attachment.sig>