[LLVMdev] [lld] r228401 - Revert "[Core] Update ContentPermissions"

[Shankar Easwaran]

Can we have a map of permissions to flavor specific permissions in the 
LinkingContext / ArchHandler ?

On 2/6/2015 8:55 AM, Shankar Easwaran wrote:
> Author: shankare
> Date: Fri Feb  6 08:55:40 2015
> New Revision: 228401
>
> URL: http://llvm.org/viewvc/llvm-project?rev=228401&view=rev
> Log:
> Revert "[Core] Update ContentPermissions"
>
> This reverts commit r228381.
>
> The MachO writer uses the permissions as bit masks.
>
> Modified:
>      lld/trunk/include/lld/Core/DefinedAtom.h
>
> Modified: lld/trunk/include/lld/Core/DefinedAtom.h
> URL: http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/DefinedAtom.h?rev=228401&r1=228400&r2=228401&view=diff
> ==============================================================================
> --- lld/trunk/include/lld/Core/DefinedAtom.h (original)
> +++ lld/trunk/include/lld/Core/DefinedAtom.h Fri Feb  6 08:55:40 2015
> @@ -157,14 +157,14 @@ public:
>     // important, because the layout pass may sort atoms by permission if other
>     // attributes are the same.
>     enum ContentPermissions {
> -    perm___,           // mapped as unaccessible
> -    permR__,           // mapped read-only
> -    permRW_,           // mapped readable and writable
> -    permRW_L,           // initially mapped r/w, then made read-only
> -                        // loader writable
> -    permR_X,            // mapped readable and executable
> -    permRWX,            // mapped readable and writable and executable
> -    permUnknown         // unknown or invalid permissions
> +    perm___  = 0,           // mapped as unaccessible
> +    permR__  = 8,           // mapped read-only
> +    permRW_  = 8 + 2,       // mapped readable and writable
> +    permRW_L = 8 + 2 + 1,   // initially mapped r/w, then made read-only
> +                            // loader writable
> +    permR_X  = 8 + 4,       // mapped readable and executable
> +    permRWX  = 8 + 2 + 4,   // mapped readable and writable and executable
> +    permUnknown = 16        // unknown or invalid permissions
>     };
>   
>     enum SectionChoice {
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits
>
>


-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by the Linux Foundation