[llvm-dev] Any objections to moving ObjCARC analysis passes to llvm/Analysis?

Duncan P. N. Exon Smith via llvm-dev llvm-dev at lists.llvm.org
Mon Aug 17 15:24:46 PDT 2015


> On 2015-Aug-14, at 08:51, Philip Reames via llvm-dev <llvm-dev at lists.llvm.org> wrote:
> 
> 
> 
> On 08/13/2015 08:53 PM, Chandler Carruth via llvm-dev wrote:
>> Currently these leave in lib/Transforms/ObjCARC even though they are analysis passes. This seems confusing and odd. In particular, Analysis/Passes.h talks about ObjCARCAliasAnalysis. =/
>> 
>> I'd like to just move the analysis headers to live under include/llvm/Analysis and the source under lib/Analysis. This will preclude omitting the ObjC ARC analysis passes from your build of LLVM if you don't care about them, but considering the number of dead-by-default passes in LLVM, this really doesn't seem like a significant concern. It also separates the language-specific bits a bit, but I'd rather have things correctly grouped by analysis and transform.
> +1

Makes sense to me too.

>> 
>> If folks are seriously concerned about this, I could alternatively create an ObjCARC directory under Analysis, but that really seems like overkill. I think the name prefix is probably enough to distinguish things.
> I would mildly prefer a sub-directory if there was more than (say) 3-4 files.  Not a strong preference.  
>> 
>> Thoughts?
>> -Chandler
>> 
>> 
>> _______________________________________________
>> LLVM Developers mailing list
>> 
>> llvm-dev at lists.llvm.org         http://llvm.cs.uiuc.edu
>> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev
> 
> _______________________________________________
> LLVM Developers mailing list
> llvm-dev at lists.llvm.org         http://llvm.cs.uiuc.edu
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-dev



More information about the llvm-dev mailing list