[LLVMdev] [RFC] Raise minimum required CMake version to 3.0

Jonathan Roelofs jonathan at codesourcery.com
Wed Apr 8 15:39:37 PDT 2015



On 4/8/15 4:36 PM, Zachary Turner wrote:
> By that logic we shouldn't have an 80 column limit in LLVM :)

Mind posting a link to the commit here so we can all second-guess your 
fix? ;)

(More seriously, it'd be a useful breadcrumb for future CMake 3.0 
discussions.)


Jon

>
> On Wed, Apr 8, 2015 at 3:35 PM Sean Silva <chisophugis at gmail.com
> <mailto:chisophugis at gmail.com>> wrote:
>
>     On Wed, Apr 8, 2015 at 1:32 PM, Zachary Turner <zturner at google.com
>     <mailto:zturner at google.com>> wrote:
>
>         When the line is like 400 characters, it's pretty obnoxious.
>
>
>
>     I guess I'd need to see the particular situation, but in my
>     experience most editors will wrap the line for you in a
>     reasonable-enough way.
>
>     -- Sean Silva
>
>
>         On Wed, Apr 8, 2015 at 1:32 PM Sean Silva <chisophugis at gmail.com
>         <mailto:chisophugis at gmail.com>> wrote:
>
>             On Wed, Apr 8, 2015 at 1:19 PM, Zachary Turner
>             <zturner at google.com <mailto:zturner at google.com>> wrote:
>
>                 Just found another issue with CMake versions prior to
>                 3.0. I need to write a long string, and prior to 3.0
>                 there is no line continuation for quoted arguments.
>                 This might seem minor, but it's one of those things that
>                 when you need to do it, it's really annoying for there
>                 to be no good workaround  :-/
>
>
>             Can't you just use longer lines? Seems pretty straightforward.
>
>             -- Sean Silva
>
>
>
>                 http://www.cmake.org/cmake/help/v3.0/manual/cmake-language.7.html#quoted-argument
>
>                 "
>
>                 Note
>
>                 CMake versions prior to 3.0 do not support continuation
>                 with \. They report errors in quoted arguments
>                 containing lines ending in an odd number of \ characters."
>
>
>
>                 On Mon, Mar 16, 2015 at 11:21 AM Renato Golin
>                 <renato.golin at linaro.org
>                 <mailto:renato.golin at linaro.org>> wrote:
>
>
>                     On 16 March 2015 at 18:00, Zachary Turner
>                     <zturner at google.com <mailto:zturner at google.com>> wrote:
>                      > We can always just say "if you want to self host,
>                     you need 3.0 or higher",
>                      > but thought I would add this to the thread anyway.
>
>                     I think that would be wiser, especially it being an
>                     undocumented
>                     feature. But thanks for the heads up.
>
>                     cheers,
>                     --renato
>
>                 _______________________________________________
>                 LLVM Developers mailing list
>
>                 LLVMdev at cs.uiuc.edu <mailto:LLVMdev at cs.uiuc.edu>
>                 http://llvm.cs.uiuc.edu
>                 http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
>

-- 
Jon Roelofs
jonathan at codesourcery.com
CodeSourcery / Mentor Embedded



More information about the llvm-dev mailing list