[LLVMdev] inconsistent wording in the LangRef regarding "shl nsw"

David Majnemer david.majnemer at gmail.com
Mon Apr 6 15:34:40 PDT 2015


On Mon, Apr 6, 2015 at 11:26 AM, Sanjoy Das <sanjoy at playingwithpointers.com>
wrote:

> > I wouldn't be surprised if InstSimplify were relying on (1) to implement
> > some of its optimizations:
> >
> http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/InstructionSimplify.cpp?revision=233938&view=markup#l2298
>
> Yup!  It looks like LLVM really implements (1) and (2) is just a
> misleading anecdote.  So I'll change my vote from "remove (1)" to
> "remove (2)".  :)
>

I wrote those optimizations with an understanding that (1) was the one true
way.  Would you be apposed to switching to (2)? I have examples where
implementing (1) creates real regressions where (2) does not.


>
> -- Sanjoy
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20150406/3f42a5fe/attachment.html>


More information about the llvm-dev mailing list