[LLVMdev] [cfe-dev] Commit message policy?

Hal Finkel hfinkel at anl.gov
Thu Sep 25 09:26:24 PDT 2014


----- Original Message -----
> From: "Renato Golin" <renato.golin at linaro.org>
> To: "Reid Kleckner" <rnk at google.com>
> Cc: "Clang Dev" <cfe-dev at cs.uiuc.edu>, "LLVM Dev" <llvmdev at cs.uiuc.edu>
> Sent: Thursday, September 25, 2014 11:14:37 AM
> Subject: Re: [LLVMdev] [cfe-dev] Commit message policy?
> 
> On 25 September 2014 16:52, Reid Kleckner <rnk at google.com> wrote:
> > That seems mostly reasonable. I'd try to make it more concise,
> > though. The
> > coding standards and developer policy docs should be short.
> 
> Right, version 2 attached. Does everyone agree with it?

I think this looks good. I'd say, "because that fits better" instead of "since that'd fit better".

Also, I'd like to add a note that all commit references should be to svn revision numbers, and not git hashes from a git mirror. In addition, all reverts must provide a rational.

Thanks,
Hal

> 
> cheers,
> --renato
> 
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
> 

-- 
Hal Finkel
Assistant Computational Scientist
Leadership Computing Facility
Argonne National Laboratory



More information about the llvm-dev mailing list