[LLVMdev] proposal to avoid zlib dependency.
Dan Liew
dan at su-root.co.uk
Sat Sep 20 11:26:51 PDT 2014
On 18 September 2014 16:59, Reid Kleckner <rnk at google.com> wrote:
> I also want to point out that there is prior art for bundling these types of
> single-source-file utility libraries in lib/Support. We have MD5.cpp,
> ConvertUTF.cpp, and reg*.c implementing various bits of functionality.
> Adding a miniz.c doesn't seem like that big of a deal.
I should of taken a look at miniz first! It is pretty small. I guess provided
1.The library code is properly namespaced to prevent symbol clashes
for LLVM clients that already use miniz directly or indirectly.
2. Someone takes ownership over this code inside LLVM
then this is probably fine. Sorry I have a bit of knee-jerk reaction
where I hear about embedding libraries because it's caused me problems
in the past.
Would the aim be to use miniz as a fallback if libz isn't available or
we want always use miniz?
I'll submit the patch that started to be developed in this thread to
llvm-commits for review anyway as it might be useful to have it in
trunk.
More information about the llvm-dev
mailing list