[LLVMdev] compiler-rt with MSVC 2013

[Aaron Ballman]

I think this issue is that we were not using the INTERCEPTOR macros to
define these functions. The following patch seems to work for me to
get the build linking again, however, I cannot test -- when I run
check-asan, I get:

2>  lit.py: lit.common.cfg:59: fatal: Invalid llvm_tools_dir config
attribute: 'E:/llvm/2013/$(Configuration)/bin'

~Aaron

On Thu, Oct 23, 2014 at 1:20 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
> On Thu, Oct 23, 2014 at 1:18 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
>> http://llvm.org/bugs/show_bug.cgi?id=21241
>> ?
>
> Yuuuup, looks like that's it. :-) I'll see if I can debug and fix.
>
> Thanks!
>
> ~Aaron
>
>>
>> 2014-10-23 10:18 GMT-07:00 Aaron Ballman <aaron at aaronballman.com>:
>>> On Thu, Oct 23, 2014 at 1:15 PM, Aaron Ballman <aaron at aaronballman.com> wrote:
>>>> On Thu, Oct 23, 2014 at 1:13 PM, Timur Iskhodzhanov <timurrrr at google.com> wrote:
>>>>> Yes it is.
>>>>> Are you doing a Debug or Release build?
>>>>> Using ninja?
>>>>
>>>> Release build, cmake + MSVC (not using ninja).
>>>>
>>>> Perhaps I have it configured stupidly; I have it as an out-of-tree folder, did:
>>>>
>>>> E:\llvm\crt_build>cmake -DLLVM_CONFIG_PATH=E:\llvm\2013\Debug\bin -G
>>>> "Visual Studio 12" ..\compiler-rt
>>>
>>> Sorry, that should read:
>>>
>>> E:\llvm\crt_build>cmake
>>> -DLLVM_CONFIG_PATH=E:\llvm\2013\Debug\bin\llvm-config.exe -G "Visual
>>> Studio 12" ..\compiler-rt
>>>
>>> ~Aaron
>>>>
>>>> Opened up the solution, hit Build All.
>>>>
>>>> ~Aaron
>>>>
>>>>>
>>>>> 2014-10-23 9:51 GMT-07:00 Aaron Ballman <aaron at aaronballman.com>:
>>>>>> Hello! I'm wondering whether compiler-rt is expected to be buildable
>>>>>> with MSVC 2013. I am currently getting:
>>>>>>
>>>>>> Error 49 error LNK2005: _free already defined in asan_malloc_win.obj
>>>>>> E:\llvm\crt_build\lib\asan\MSVCRT.lib(MSVCR120.dll)
>>>>>>
>>>>>> Which seems to be the only issue (aside from ~50 warnings, which I'll
>>>>>> happily work on cleaning up). I get this when I build the ALL_BUILD
>>>>>> project in the solution from cmake.
>>>>>>
>>>>>> Thanks!
>>>>>>
>>>>>> ~Aaron
>>>>>> _______________________________________________
>>>>>> LLVM Developers mailing list
>>>>>> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
>>>>>> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
-------------- next part --------------
A non-text attachment was scrubbed...
Name: asan_malloc_win.cc.patch
Type: application/octet-stream
Size: 3409 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141023/c0276aff/attachment.obj>