[LLVMdev] lld coding style

Manuel Klimek klimek at google.com
Fri Oct 10 03:59:43 PDT 2014


On Fri Oct 10 2014 at 3:09:16 AM Nico Rieck <nico.rieck at gmail.com> wrote:

> On 10.10.2014 02:51, Sean Silva wrote:
> > On Wed, Oct 8, 2014 at 10:59 AM, Manuel Klimek <klimek at google.com>
> wrote:
> >> On a different note:
> >> My favorite feature of Phabricator: if you look at a file in blame mode,
> >> there are little "<<" next to the revision, which lets you jump to the
> file
> >> "past that revision". This lets one quickly browse to the right point
> for
> >> what one is looking for, making naming or formatting changes less
> >> burdensome.
> >> Example:
> >> http://reviews.llvm.org/diffusion/L/browse/cfe/trunk/
> include/clang/Basic/DiagnosticIDs.h;198376
> >>
> >
> >
> > That is really great! I need this from time to time and though it's not
> > difficult to approximate on the command line, it is tedious. This saves a
> > lot of work!
>
> You can also do this easily without Phab just by using git (with "git
> gui blame <path>"). This also detects copies/moves.
>

Just tried that and I don't see how to get to the *parent* commit of a line
(the immediate version of the file before it was the way I see it).
With git this is probably hard, because it assumes non-linear history, so
there is not necessarily a single parent commit (?)


>
> -Nico
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141010/b7d6293f/attachment.html>


More information about the llvm-dev mailing list