[LLVMdev] lld coding style

[Rui Ueyama]

On Mon, Oct 6, 2014 at 6:03 PM, Nick Kledzik <kledzik at apple.com> wrote:

> On Oct 6, 2014, at 5:02 PM, Rui Ueyama <ruiu at google.com> wrote:
>
> On Mon, Oct 6, 2014 at 5:00 PM, Nick Kledzik <kledzik at apple.com> wrote:
>
>> On Oct 6, 2014, at 3:44 PM, Rui Ueyama <ruiu at google.com> wrote:
>>
>> Looks like most people in this thread support using LLVM style in LLD. I
>> also had an offline discussion and many people wanted to have one coding
>> style in all LLVM projects. So I'm convinced that we should do that.
>>
>> I'm going to create a patch to rename all variables if no one objects.
>>
>> I object!
>>
>
> I'd like to hear the reason. :)
>
>
> Up until now the thread has been about “formatting”.  You suggested
> renaming every variable in the project!
>

In this thread we all have been discussing coding style from the beginning.
LLD's formatting rule is the same as LLVM so the rest is naming convention.

On Oct 6, 2014, at 5:37 PM, Chris Lattner <clattner at apple.com> wrote:
>
> Right.  Specifically, why is it for the “greater good” to perpetuate a
> schism between lld and the rest of llvm?
>
> Well to turn this around, why is llvm maintaining a schism with the rest
> of the C++ world?  That is, lld (and probably lldb) is more like all the
> other C++ conventions in the world than llvm is.  If llvm had conventions
> like every other convention, it would be easier for outside developers to
> contribute to llvm and improve the "greater good".
>

I understand what you mean. If I would start a project myself, I would
adopt more regular-looking C++ coding style than LLVM.

However, the point is that LLD is a LLVM project. Most LLVM projects follow
the LLVM coding style already. I think it's better to set personal
preferences aside and follow the LLVM standard. That's what I'd do.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141007/7edb5ead/attachment.html>