[LLVMdev] How do I update Ocaml debug info? (was Re: [llvm] r218914 - DI: Fold constant arguments into a single MDString)

[Reid Kleckner]

Better to do something like CHECKX, since the rest of OCaml IR generation
should still work, and it's primarily tested in that one file.

I think it's reasonable to file a PR about it and temporarily regress OCaml
debug info generation. It would be good if line information worked, though.

On Thu, Oct 2, 2014 at 3:48 PM, Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:

> -llvm-commits, +llvmdev
>
> > On Oct 2, 2014, at 2:57 PM, Duncan P. N. Exon Smith <
> dexonsmith at apple.com> wrote:
> >
> > Author: dexonsmith
> > Date: Thu Oct  2 16:56:57 2014
> > New Revision: 218914
> >
> > URL: http://llvm.org/viewvc/llvm-project?rev=218914&view=rev
> > Log:
> > DI: Fold constant arguments into a single MDString
> >
> > This patch addresses the first stage of PR17891 by folding constant
> > arguments together into a single MDString.  Integers are stringified and
> > a `\0` character is used as a separator.
> >
> > Part of PR17891.
> >
> > Note: I've attached my testcases upgrade scripts to the PR.  If I've
> > just broken your out-of-tree testcases, they might help.
> >
>
> Among other things, this commit broke the Ocaml debug info test [1].
> It's not obvious to me how to fix it (I don't speak Ocaml).  Anyone know
> what to do?  (Is it reasonable for me to just XFAIL it, file a PR, and
> move on?)
>
> [1]: http://lab.llvm.org:8011/builders/llvm-hexagon-elf/builds/11579
>
> _______________________________________________
> LLVM Developers mailing list
> LLVMdev at cs.uiuc.edu         http://llvm.cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/llvmdev
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141002/26b08028/attachment.html>