[LLVMdev] Proposed patches for Clang 3.5.1

[Tom Stellard]

On Mon, Nov 24, 2014 at 04:33:28PM +0000, Daniel Sanders wrote:
> Hi,
> 
> I'd like to propose the following patches for inclusion in Clang 3.5.1.
> 
> Proposed clang patches:
> 
> *         r213769 - Fix test/Driver/cl-x86-flags.c by providing explicit -target
> 

This one seems OK, but I would feel better if the X86 code owner approved
it too.  Could you be pull this request into a separate mail and cc him.

> *         r214025 - [Driver][Mips] Check output of -dynamic-linker arguments by the Clang driver
> 
> *         r214662 - [Mips] Add the `mips64-linux-gnu` target to the test case to check `in128`  type handling.
> 
> *         r217147 - [mips] Zero-sized structs cannot be ignored in MipsABIInfo::classifyReturnType() for O32

These look OK to me you you can merge them to the 3.5 branch yourself,
or if you aren't comfortable with this, I can do it.  If you decide
to merge them yourself, make sure you use the merge script so we get a
consistent commit message format: utils/release/merge.sh

Note this only works with SVN.  If you use git, you may need to manually paste
the svn commit log.

> 
> Proposed llvm patches:
> 
> *         r216920 - Fix left shifts of negative values in MipsDisassembler.
> 
> *         r221408 - [mips64] Fix MIPS64 exception personality encoding
> 
> *         r221453 - [mips] Tolerate the use of the %z inline asm operand modifier with non-immediates.
> 
> *         r216262 - [mips] Don't use odd-numbered float registers for double arguments for fastcc calling convention if FP is 64-bit and +nooddspreg is used.
> 

This all look OK to me, go ahead an merge.

> *         r217257 - [mips] Change Feature-related types from unsigned to uint64_t in MipsAsmParser. No functional changes.
> 

I'm a little concerned this might break the shared library ABI.  We will need
to verify that it doesn't before it gets merged.

> *         r218745 - [mips] Fix disassembly of [ls][wd]c[23], cache, and pref
> 

This looks OK to me.

> I'd also like to propose the inclusion of the recent ABI fixes to the Mips target but I'm not sure this is a good idea. I'm having difficulty sorting out the dependencies for these at the moment since they seem to depend on some of Eric Christopher's Subtarget/TargetMachine refactoring. It may also be a bit large for a stable release since it's ~50 LLVM patches and ~8 Clang patches and refactors a large amount of the Mips calling convention code. What do you think?
> 

Can you give me an idea of how important these fixes are?  My personal
feeling is that big fixes like this can sometimes be OK as long as they
are mostly contained to a specific target and that target isn't X86
or ARM.  In this case, it would help too if you could provide some release
testing for MIPS.

Are you planning on back-porting these patches to 3.5 for personal use,
even if they aren't going to be included in the official release?

-Tom

> Daniel Sanders
> Leading Software Design Engineer, MIPS Processor IP
> Imagination Technologies Limited
> www.imgtec.com<http://www.imgtec.com/>
>