[LLVMdev] [llvm][SelectionDAG] trivial patch: fix misprint in SelectionDAGLegalize::ExpandInsertToVectorThroughStack
Owen Anderson
resistor at mac.com
Tue Nov 18 12:50:43 PST 2014
r222254
—Owen
> On Nov 18, 2014, at 1:22 AM, Daniil Troshkov <troshkovdanil at gmail.com> wrote:
>
> I have no commit access. Please commit it...
>
> Thank you!
>
> On Mon, Nov 17, 2014 at 9:16 PM, Owen Anderson <resistor at mac.com> wrote:
> Alright, go ahead with it.
>
> —Owen
>
>> On Nov 17, 2014, at 4:58 AM, Daniil Troshkov <troshkovdanil at gmail.com> wrote:
>>
>> Hi!
>>
>> I have not found test case. (It is because we have no target using "ExpandInsertToVectorThroughStack").
>> But I tested it for target currently not included in llvm trunk.
>>
>> This fix correct and trivial, so I'm offering to commit it...
>>
>> On Wed, Nov 12, 2014 at 11:47 PM, Daniil Troshkov <troshkovdanil at gmail.com> wrote:
>> I detected this bug using test case from platform which is not currently supported on llvm targets. (Our team is porting llvm on new target).
>> Creating the test case will take some extra time. I'll try to do it ASAP.
>> Have you any ideas about the test case? (targets using ExpandInsertToVectorThroughStack, etc...)
>>
>>
>> On Wed, Nov 12, 2014 at 8:29 PM, Owen Anderson <resistor at mac.com> wrote:
>> LGTM. Can you supply a testcase?
>>
>> —Owen
>>
>> > On Nov 12, 2014, at 5:52 AM, Daniil Troshkov <troshkovdanil at gmail.com> wrote:
>> >
>> > Hi Owen!
>> >
>> > The "First store the whole vector" is without uses and will be deleted later.
>> > I've attached trivial patch to fix it.
>> > I have no commit access so if patch is OK, please, commit it .
>> >
>> > Danil.
>> > <ExpandInsertToVectorThroughStack.patch>
>>
>>
>>
>
>
More information about the llvm-dev
mailing list