[LLVMdev] [RFC] Embedding command line options in bitcode (PR21471)
Eric Christopher
echristo at gmail.com
Fri Nov 14 15:24:24 PST 2014
On Fri Nov 14 2014 at 3:23:37 PM Duncan P. N. Exon Smith <
dexonsmith at apple.com> wrote:
>
> > On 2014-Nov-14, at 15:07, Eric Christopher <echristo at gmail.com> wrote:
> >
> >
> > > d) linkonce_odr functions with different attributes
> >
> > Doesn't this just get handled by lib/Linker? I figure we keep the
> > attributes of the version of the function that "wins".
> >
> >
> > Right. Which one wins? You'll get inconsistent results depending on
> ordering. Of course, you'd get that without linking them, but we should do
> some sort of checking ideally.
>
> You mean some lib/Linker tests, to make sure that the version of the
> function that wins has its own attributes attached, instead of those
> of one of the losing functions? Yup, makes sense.
Or perhaps a warning on "you said these two things were identical...
they're not" with some calls into the backend.
-eric
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20141114/ae6200df/attachment.html>
More information about the llvm-dev
mailing list