[LLVMdev] Contributing the Apple ARM64 compiler backend

Tobias Grosser tobias at grosser.es
Sat Mar 29 00:24:31 PDT 2014


On 03/28/2014 11:27 PM, Alex Rosenberg wrote:
> My suggestions:
>
> 1. Do #1 below as you suggested as quickly as feasible.
> 2. String up and flog any and all executives and lawyers who forced the world to wait since September for this. Perhaps beat them with a big stick labeled "Technical Debt."
> 3. A few minor review things that popped out at me:
>
> libc++: _LIBCPP_NONUNIQUE_RTTI_BIT needs a block comment to explain why.
> llvm:
>    include/LLVM/MC/MCAsmInfo.h: ^meast^means
>    Linker Optimization Hints seem to be documented in Radar. Perhaps a bit more commenting in here?
>    I also saw a few 80-column violations scroll by, and several first line comment length issues as well.

Thanks to clang-format such style issues should be a no-brainer. It 
should definitely be run before integration.

Tobias



More information about the llvm-dev mailing list