[LLVMdev] [cfe-dev] [RFC] Moving OnDiskHashTable from clang to LLVM

Jordan Rose jordan_rose at apple.com
Mon Mar 24 09:34:41 PDT 2014


I like this idea. I would think that most of the endian-reading functions can be replaced by what's currently in llvm/Support/Endian.h. The writing functions...well, I'm not sure. They're not necessarily going to be useful anywhere else.

Jordan


On Mar 22, 2014, at 1:31 , Justin Bogner <mail at justinbogner.com> wrote:

> I would like to use the on disk hash table that's currently in clang for
> instrumentation based profiling. This is a single header file that's
> currently found in include/clang/Basic/OnDiskHashTable.h, and I
> propose to move it to include/llvm/Support/OnDiskHashTable.h.
> 
> Any strong objections to moving this?
> 
> Also, the header includes a "clang::io" namespace with some operations
> for reading and writing little endian files. Should these be directly
> renamed to "llvm::io", or would something like "llvm::endian::little" or
> "llvm::le" be more reasonable?
> _______________________________________________
> cfe-dev mailing list
> cfe-dev at cs.uiuc.edu
> http://lists.cs.uiuc.edu/mailman/listinfo/cfe-dev




More information about the llvm-dev mailing list