[LLVMdev] [lld] Relocation reading refactoring

[Simon Atanasyan]

Hi Shankar,

I've implemented the option "A" at r203408:
http://llvm.org/viewvc/llvm-project?rev=203408&view=rev

On Thu, Mar 6, 2014 at 6:05 PM, shankarke <shankarke at gmail.com> wrote:
> We could stick to option A and implement or move to option B need be.
>
> Sent from my iPhone
>
> On Mar 6, 2014, at 1:58, "Simon Atanasyan-2 [via LLVM]" <[hidden email]>
> wrote:

[...]

> A:
> =====
> 1. Factor out `ELFReference` creation from
> `createDefinedAtomAndAssignRelocations` into a couple of virtual
> functions with the following signature:
>
> ELFReference<ELFT> *
> createRelocationReference(const Elf_Sym &symbol, const Elf_Rela &rai);
>
> ELFReference<ELFT> *
> createRelocationReference(const Elf_Sym &symbol, const Elf_Rel &ri,
>                           ArrayRef<uint8_t> content);
>
> 2. Override one or both these methods in the <target name>ELFFile class.

-- 
Simon