[LLVMdev] [RFC] The coding standard for "struct" should be relaxed or removed

Duncan P. N. Exon Smith dexonsmith at apple.com
Sat Mar 1 17:59:24 PST 2014


The current guidelines [1] on the use of the struct keyword are too
restrictive and apparently ignored.  They limit the use of struct to
PODs, citing broken compilers.

The guidelines are out-of-date and should be relaxed.  Here’s why:

 1. Our updated list of supported compilers should all deal correctly
    with non-POD structs.

 2. A quick grep of the source suggests that no one paid attention
    anyway.

I’ve attached a patch that removes the guideline entirely (matching
the apparent current practice), but does anyone feel a new explicit
guideline is in order?

[1]: http://llvm.org/docs/CodingStandards.html#use-of-class-and-struct-keywords

-------------- next part --------------
A non-text attachment was scrubbed...
Name: remove-struct-guidelines.patch
Type: application/octet-stream
Size: 1221 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140301/6208807f/attachment.obj>


More information about the llvm-dev mailing list