[LLVMdev] Phabricator and private reviews

[Manuel Klimek]

On Thu, Jun 26, 2014 at 11:34 AM, Daniel Sanders <Daniel.Sanders at imgtec.com>
wrote:

> > As I understand, some people legitimately use Phabricator for internal
> > review, ...
>
> MIPS currently do this for patches that only touch the MIPS backend
> (details can be found at
> http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20140602/220385.html).
> Any patch that touches common code is sent to the list. One thing I haven't
> said on that thread yet is that I'm considering trying the 'everything to
> llvm-commits' workflow myself in a couple weeks when my urgent work is
> finished. I have some reservations about that workflow but I'm willing to
> try it to see if my concerns are justified or not.
>

Not knowing your concerns, I'd say they are mostly unjustified ;)


> Manuel: I'm aware of one other way for a review to be invisible to
> llvm-commits despite being CC'd. If you forget to CC llvm-commits when
> creating the differential revision and add it later in the web interface,
> Phabricator doesn't send an email to the list. Adding a comment (at the
> same time or afterwards) triggers an email.
> The same thing happens when adding reviewers without a comment.
>

That is intentional. We don't want to spam the list with changes in phab -
use phab like you would use email, and everything should be fine.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140626/c26bf146/attachment.html>