[LLVMdev] Phabricator and private reviews

Manuel Klimek klimek at google.com
Wed Jun 25 14:18:56 PDT 2014


On Wed, Jun 25, 2014 at 10:43 PM, Alp Toker <alp at nuanti.com> wrote:

>
> On 25/06/2014 23:35, Reid Kleckner wrote:
>
>  On Wed, Jun 25, 2014 at 11:57 AM, Nick Lewycky <nicholas at mxc.ca <mailto:
>> nicholas at mxc.ca>> wrote:
>>
>>     PS. I caused a few of these recently, my email in phab was set to
>>     an account that isn't subscribed to llvm-commits, so my reviews
>>     were held for moderation. Fixed on my end.
>>
>>
>> I think this is probably a fairly common cause of lost review mail.  I
>> updated the Phab documentation in r211731 to try to clarify this.  Feel
>> free to improve on that if I missed something.
>>
>> Alp, does r211731 help address your concerns?
>>
>
> Cool, that makes sense.
>
> Is there a container image of the llvm.org Phabricator setup available?
>
> I'd like to have a shot at enforcing this or at least present a hint in
> the UI of the web app but I couldn't figure out where the container is
> hosted.


Help would be highly appreciated, awesome!
https://github.com/r4nt/llvm-reviews/blob/master/bootstrap-phab.sh
Gives you a phab install that basically matches our setup if you replace
r4nt-master with r4nt-staging for the branch of the mirrored phab repos.

Cheers,
/Manuel


>
>
> Alp.
>
>
> --
> http://www.nuanti.com
> the browser experts
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-dev/attachments/20140625/30955423/attachment.html>


More information about the llvm-dev mailing list