[LLVMdev] sys::path::system_temp_directory vs. sys::fs::createTemporaryFile

[Jordan Rose]

On Jul 25, 2014, at 13:44 , Rafael Espíndola <rafael.espindola at gmail.com> wrote:

> On 25 July 2014 16:31, David Majnemer <david.majnemer at gmail.com> wrote:
>> I have a few concerns:
>> 1. GetTempPathW is buggy, we should be manually using
>> GetEnvironmentVariableW with TMP, TEMP and USERPROFILE arguments and use the
>> first that exists.
>> 2. We should make sure that the platform specific pieces live in their
>> respective Path.inc files.
>> 
> 
> But that is orthogonal, no?
> 
> If I understand correctly, Jordan's question is "do we need both
> system_temp_directory and TempDir"? I doesn't look like it, it seems
> that every user of TempDir could be replaced with
> system_temp_directory.

Well, part of my original point is that TempDir is smarter than system_temp_directory in a few ways. I suppose the Windows implementation isn't one of them.