[LLVMdev] [patch] EXPORTED_SYMBOL_FILE using mingw and cmake

Dan Liew dan at su-root.co.uk
Wed Jul 23 12:30:36 PDT 2014


On 23 July 2014 19:45, Mueller-Roemer, Johannes Sebastian
<Johannes.Sebastian.Mueller-Roemer at igd.fraunhofer.de> wrote:
> The new patch works fine, but considering the discussion on the CMake bug tracker, I'm would say that TO_NATIVE_PATH shouldn't be used at all.

I'm happy either way. A patch using string(REPLACE ...) instead for
all cases I think would be fine provided it has a comment saying
something like...

# Don't use file(TO_NATIVE_PATH ...) it doesn't work correctly when
generating MingW Makefiles
string(REPLACE / \\ export_file_backslashes "${export_file}")

so that someone doesn't try and start using file(TO_NATIVE_PATH ...)
again at some point. It would also be cleaner I guess.



More information about the llvm-dev mailing list