[LLVMdev] LLVM commit 410f38e01597120b41e406ec1cea69127463f9e5

[Matt Arsenault]

On Jul 5, 2014, at 7:14 PM, deadal nix <deadalnix at gmail.com> wrote:

> OK, so in you case, you want DAG.getSExtOrTrunc(SetCC, DL, SelectVT) to tunc the result from i64 to i32 on 64 bits targets, if I understand correctly.
> 
> 2 questions:
>  - Why not generating a selectcc node directly ? It avoid having to mess up with intermediate values.
Well first, that’s what it did originally and wasn’t what I was changing. selectcc might not be legal, and I’m not sure why it even exists.  I don’t see how it’s any harder to match select + setcc vs. selectcc, and selectcc just gives you another case to worry about.


>  - Why calling getSetCCResultType(VT) ? VT is not the type of a parameter of setcc, and this looks incorrect to me.
That’s what it did originally, and what I fixed. It now checks getSetCCResultType of the operand’s operand’s value type, the setcc’s operand