[LLVMdev] Usability of phabricator review threads for non-phab-users

[Philip Reames]

On 07/01/2014 04:11 AM, Manuel Klimek wrote:
> Alp noted that the current setup on how phab reviews land on the list 
> are not working for him. I'd be curious whether his setup is special, 
> or whether there are more widespread problems. If this is more widely 
> perceived as a problem, please speak up, and I'll make sure to 
> prioritize the fixes (note that this is unrelated to the "lost email" 
> problem - those are always highest priority and as far as I'm aware we 
> diagnosed and fixed all of them within 1-2 business days).
>
> If you have the feeling that the phab email workflow makes it hard for 
> you to jump into reviews, keep track of reviews, or understand reviews 
> if you're not a phab user, please reply to this thread. You don't need 
> to provide details, "+1", "please fix", or "doesn't work well for me" 
> are all acceptable replies here - I want to get a feeling for the 
> magnitude of the problem.
>
> Thanks,
> /Manuel
I generally prefer phabricator for longer or more detailed reviews. I 
will sometimes respond directly through the list for small patches when 
the code is obvious.

A few issues I've noticed:
- Confusion around adding llvm-commits
- Confusion around when email is actually sent.  Particularly with the 
approve and close steps.
- Phab doesn't recognize LGTM in an email response

Philip